Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop layer loading spinner when layer is removed #903

Merged

Conversation

clydebw
Copy link
Contributor

@clydebw clydebw commented Dec 12, 2021

This fixes a problem where if show_loading is True for a layer, and this layer is removed from the map prior to all tiles being loaded, the loading spinner for this layer continues to spin and is stuck on the map indefinitely.

It is noted that this tends to only be a problem for layers that take a good amount of time to load. Otherwise, under practical circumstances, it is unlikely that a layer remove event would fire before the load event. Therefore, to reproduce the problem described above, you will either need to find a tile layer that is slow to load, or otherwise temporarily disable the bit of code that stops the loading spinner upon the load event.

(Also, this is my first contribution here! If I should be opening an issue or something like that, let me know!)

@clydebw clydebw marked this pull request as ready for review December 12, 2021 18:12
@martinRenou
Copy link
Member

Thanks!

@martinRenou martinRenou merged commit 372a37a into jupyter-widgets:master Dec 13, 2021
@clydebw clydebw deleted the fix-loading-spinner branch June 9, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants